Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the week with the Monday when ISO week calculation #3685

Closed
wants to merge 1 commit into from
Closed

Use the week with the Monday when ISO week calculation #3685

wants to merge 1 commit into from

Conversation

laoneo
Copy link
Contributor

@laoneo laoneo commented May 19, 2017

When the start date of the week is set to Sunday and the week number calculation is set to ISO, then the weeknumber is shown of the week from the Sunday.
Does it make sense to show the week number of the first Monday in the row?

@arshaw
Copy link
Member

arshaw commented Jul 14, 2017

I'd hate to put another week number edge case here.

Is this a scenario that people want? Wouldn't the vast majority of people who want to display ISO week numbers also have their weeks begin with Monday?

@laoneo
Copy link
Contributor Author

laoneo commented Jul 18, 2017

A user of my Joomla extension had it the way that he wanted to show the week numbers in ISO format but the week was starting on Sunday. According to wikipedia you are right, the ISO week starts with Monday https://en.wikipedia.org/wiki/ISO_week_date.

@jjnxpct
Copy link

jjnxpct commented Aug 10, 2018

Hi! We would also like to be able to start the week on monday but have the correct weeknumber in front of the week in month view. Would it be possible to use merge the pull request by laoneo? We use his calendar extension in Joomla. Or does the pull request have a conflict that need to be resolved first?

@arshaw
Copy link
Member

arshaw commented Jul 26, 2019

this PR has been superseded by #4731

@arshaw arshaw closed this Jul 26, 2019
@laoneo laoneo deleted the fix/iso-weeknumber-calc branch July 27, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants