Fix bug preventing resizing of event from the left / delta undefined error #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the endDelta to determine the durationDelta isn't accurate. The endDelta may be undefined but startDelta may exist. If the startDelta is negative, then the duration will increase, if positive it will decrease. Thus we should sum the inverse of the startDelta with the endDelta to get the durationDelta. This shim is acting more as pseudo-code as the start/end delta objects don't implement addition and subtraction. We need to find a way to do this or alternatively use a utility to diff the start / end times from the new date definition object. This is what the eventResize callback will use anyway.
Since we already have an updated date profile, we can just diff the end and start properties instead of attempting to calculate based on the diffs. It means we achieve the same thing but can use existing utilities that support moment objects.
Go back to using the start/end deltas but just pick one or the other depending on which one has changed. Don't do fancy calulations to get the duration because it seems the durationDelta isn't really a duration delta at all... Instead, it's simply the delta of the time that has changed. The variable name should reflect this but I think I'm done for now if that makes sense :).
|
released in 3.10.0. thanks for the hard work @livmackintosh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you wish to see what this fixes, please see the JSFiddle in the below issue.
Adresses fullcalendar/fullcalendar-workspace#416