Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose resource and timeslot on right click #6044

Closed
wants to merge 0 commits into from

Conversation

bwobbones
Copy link

@bwobbones bwobbones commented Dec 25, 2020

A test for the exposure of the resource and timeslot for a right click.

Closes #2748

@bwobbones bwobbones closed this Dec 25, 2020
@bwobbones bwobbones reopened this Dec 25, 2020
@bwobbones
Copy link
Author

@acerix @arshaw any timeline on the next release?

@bwobbones
Copy link
Author

@acerix @arshaw I see that this one wasn't merged for the recent release, is there something I can to do to make it easier for you?

@merry-ma-18
Copy link

merry-ma-18 commented Apr 15, 2021

Hi. This is very helpful and I hope this will be officially integrated soon. Meanwhile I use the monkey patch version. Any chance to get this for eventClick as well please?

@melloware
Copy link

@bwobbones looks like you need to rebase this PR there are merge conflicts.

@bwobbones
Copy link
Author

Yes, I'll take care of that ASAP

@bwobbones
Copy link
Author

@melloware fixed

@bwobbones
Copy link
Author

Link to the tests: fullcalendar/fullcalendar-workspace#571
Link to the monkey patch: https://github.com/bwobbones/fullcalendar5-rightclick

@bwobbones
Copy link
Author

@merry-ma-18 lets keep this PR clean, i'll have a look into a new PR for eventClick.

@bwobbones
Copy link
Author

Can someone point me at some docs for managing the submodules here? It seems that I get a conflict with the underlying packages-premium every time I update it.

@RafaelGreen1
Copy link

any update on this issue?

@RafaelGreen1
Copy link

@bwobbones it seems like you are changing these files: "packages-premium" and "yarn.lock" in this pull request
is it really your intention to change these files?

@bwobbones
Copy link
Author

Yes, well I think so, the tests for the change are in packages-premium and those changes probably change the yarn.lock file.

@bwobbones
Copy link
Author

For my own future reference, accepting incoming for yarn.lock running this command git checkout master packages-premium fixed it.

@bwobbones
Copy link
Author

@acerix @arshaw please merge or let me know you won't so I don't have to fix this again?

@RafaelGreen1
Copy link

RafaelGreen1 commented May 23, 2021

@bwobbones @acerix @acerix In my opinion this feature is really useful and also worth documentation here: https://fullcalendar.io/docs/event-clicking-hovering

@RafaelGreen1
Copy link

hi, any update on this? thanks

@bwobbones
Copy link
Author

Not sure what to do here. When I hear from any of the devs, I'll update my PR to the latest version.

I wonder if there is no response because I'm not (yet) a paying customer? I wonder if we could get any sponsorship in here from someone that @acerix or @arshaw will respond to?

@Xample
Copy link

Xample commented Feb 16, 2022

@bwobbones I'm also in the need to get the clicked mouse information (or waiting for a dateContextmenu event). I'm using your npm hack for now…

@bwobbones
Copy link
Author

Thanks @Xample, no idea why they won't respond. I'll keep the monkey patch up to date anyway as I'm using it myself.

@pamplona007
Copy link

Any news on this? My contractor is a paying client and we need this feature

@Xample
Copy link

Xample commented Aug 18, 2022

@pamplona007 use the monkey patch I'm using it in production.

@bwobbones
Copy link
Author

Quick note to let anyone who is using it know that I've updated the monkey patch to work with FullCalendar v6.

npm i @bwobbones/fullcalendar5-rightclick

I'll fix my PR here also in the near future in the hope that @arshaw will look at it.

@bwobbones
Copy link
Author

So...I closed this by mistake. I honestly don't know what happened, I'll open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right-click on date cells
7 participants