use node 18 with pnpm

fullcalendar · Jan 4, 2024 · 03e8bc7 · 03e8bc7
1 parent 79f4284
commit 03e8bc7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,7 +28,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16.18.0
+          node-version: 18.19.0
           cache: 'pnpm'
 
       - name: Install dependencies

diff --git a/.npmrc b/.npmrc
@@ -1,7 +1,3 @@
 engine-strict = true
-
-# for some reason 16.18.0 cause sub-second tz offsets to fail
-# NOTE: keep in sync with github workflow
-use-node-version = 16.18.0
-
+use-node-version = ${NODE_VERSION:-18.19.0}
 prefer-workspace-packages = true
diff --git a/.../test-config/expected-failures-node20.txt → ...ig/expected-failures-intl-format-norm.txt b/.../test-config/expected-failures-node20.txt → ...ig/expected-failures-intl-format-norm.txt
diff --git a/packages/temporal-polyfill/scripts/test.js b/packages/temporal-polyfill/scripts/test.js
@@ -48,10 +48,13 @@ yargs(hideBin(process.argv))
         'expected-failures-surface.txt',
       ];
 
-      const nodeVersion = parseInt(process.versions.node.split('.')[0]);
-      if (nodeVersion < 18) expectedFailureFiles.push('expected-failures-before-node18.txt');
-      if (nodeVersion < 16) expectedFailureFiles.push('expected-failures-before-node16.txt');
-      if (nodeVersion === 20) expectedFailureFiles.push('expected-failures-node20.txt');
+      const nodeVersion = process.versions.node
+      const nodeMajorVersion = parseInt(nodeVersion.split('.')[0]);
+      if (nodeMajorVersion >= 18) expectedFailureFiles.push('expected-failures-intl-format-norm.txt');
+      if (nodeMajorVersion < 18) expectedFailureFiles.push('expected-failures-before-node18.txt');
+      if (nodeMajorVersion < 16) expectedFailureFiles.push('expected-failures-before-node16.txt');
+
+      console.log(`Testing with Node v${nodeVersion}...`)
 
       const result = runTest262({
         test262Dir: joinPaths(monorepoDir, 'test262'),