Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for webhookUrl and webhookId. #10

Merged
merged 1 commit into from Sep 8, 2016

Conversation

dboskovic
Copy link
Contributor

I added the ability to set your webhook callback in a request. Example below.

$fullcontact = new Services_FullContact_Person($apikey);
$fullcontact->setWebhookUrl('http://requestb.in/15zahug1');
// $fullcontact->setWebhookUrl('http://requestb.in/15zahug1','test-webhook'); // with webhookId
$result = $fullcontact->lookupByEmail('bart@fullcontact.com');

Since other endpoints use the webhookUrl, I set that on the main service rather than just the Person service. I also removed the urlencoding on the api key since http_build_query already does that.

@cdave3
Copy link

cdave3 commented Sep 8, 2016

@eentzel, can we get this merged please?

Excluding comments, its only around 10 lines of code.

@dboskovic
Copy link
Contributor Author

🏆 for the longest code review ever 😂

@CharlieSu
Copy link
Contributor

Sorry for the delay, merging this now.

@CharlieSu CharlieSu merged commit 9f2d1a1 into fullcontact:master Sep 8, 2016
@cdave3
Copy link

cdave3 commented Sep 8, 2016

Awesome! Thanks @CharlieSu 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants