Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please bundle for webpack #1

Closed
samvloeberghs opened this issue Nov 11, 2016 · 8 comments
Closed

please bundle for webpack #1

samvloeberghs opened this issue Nov 11, 2016 · 8 comments

Comments

@samvloeberghs
Copy link

No description provided.

@fulls1z3
Copy link
Owner

Hi Sam, I'm a bit new to webpack. However, I'll investigate this and try to provide a bundle for webpack in the next release. Meantime, I'll be open to any kind of co-operation.

Thanks!

@fulls1z3
Copy link
Owner

Hi, are we talking about the following issue?

WARNING in ./~/ng2-metadata/dist/bundles/ng2-metadata.umd.min.js
Critical dependencies:
1:4508-4515 require function is used in a way in which dependencies cannot be statically extracted
1:4560-4567 require function is used in a way in which dependencies cannot be statically extracted
 @ ./~/ng2-metadata/dist/bundles/ng2-metadata.umd.min.js 1:4508-4515 1:4560-4567

@samvloeberghs samvloeberghs changed the title pleas bundle for webpack please bundle for webpack Nov 21, 2016
@samvloeberghs
Copy link
Author

@fulls1z3 no, just checkout other repo's like ng2-translate and how they are delivering their package :)
thanks for your effort. Please keep in mind that this package as for now is useless.. Unless you run it on the server. No time to elaborate on it now, but look into Universal, you'll get it!

@fulls1z3
Copy link
Owner

Hi Sam, thanks for your comments. Despite I was new to webpack (fortunately now not), I am sharing the same thoughts, that the package is useless unless it successfully compiles on AoT and bundled with webpack.

Today, I was looking at the same repo (ng2-translate) as well as others (ng2-bootstrap, etc.) and I'm about to deliver the package in the same way as ng2-translate does (webpack bundle).

Please keep in mind that ng2-bootstrap is also about to deliver webpack bundles. If you clone the dev. branch (or use relevant bundled files), you'll be able to compile those components in webpack.

On the other hand, you can give a try with the attached file (ng2-metadata.umd.min.js.zip).

@samvloeberghs
Copy link
Author

@fulls1z3 it has nothing to do with aot, it's just that metadata is only usefull / indexable by all search engines / social providers if the HTML is rendered on the server. This will only work for Google's search engine, that is able to crawl heavy javascript applications.

@fulls1z3
Copy link
Owner

fulls1z3 commented Nov 21, 2016

@samvloeberghs thanks again for your comments. I'm aware that the metadata generated by this package is "dynamic" - cannot be indexed any search engines except Google, and also it's not introduced as a replacement of server-side solution to render meta tags.

Furthermore, for a complete SEO, other page elements (as well as page contents) should be rendered on the server as well (yeah - angular universal, or prerender.io, phantomjs, etc..).

However, this topic refers to webpack bundling of the repo, so I'm closing the issue as it goes off-topic.

@fulls1z3 fulls1z3 changed the title please bundle for webpack [enhancement] please bundle for webpack Mar 2, 2017
@fulls1z3 fulls1z3 self-assigned this Mar 16, 2017
@fulls1z3
Copy link
Owner

fulls1z3 commented Apr 8, 2017

Hi @sambloeverghs, as of v0.2.0-rc.5 it supports server-side rendering. Hope you're still interested in @nglibs/meta 😄

@samvloeberghs
Copy link
Author

Good job!😎

@fulls1z3 fulls1z3 changed the title [enhancement] please bundle for webpack please bundle for webpack Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants