New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
please bundle for webpack #1
Comments
Hi Sam, I'm a bit new to webpack. However, I'll investigate this and try to provide a bundle for webpack in the next release. Meantime, I'll be open to any kind of co-operation. Thanks! |
Hi, are we talking about the following issue?
|
@fulls1z3 no, just checkout other repo's like ng2-translate and how they are delivering their package :) |
Hi Sam, thanks for your comments. Despite I was new to webpack (fortunately now not), I am sharing the same thoughts, that the package is useless unless it successfully compiles on AoT and bundled with webpack. Today, I was looking at the same repo (ng2-translate) as well as others (ng2-bootstrap, etc.) and I'm about to deliver the package in the same way as ng2-translate does (webpack bundle). Please keep in mind that ng2-bootstrap is also about to deliver webpack bundles. If you clone the dev. branch (or use relevant bundled files), you'll be able to compile those components in webpack. On the other hand, you can give a try with the attached file (ng2-metadata.umd.min.js.zip). |
@fulls1z3 it has nothing to do with aot, it's just that metadata is only usefull / indexable by all search engines / social providers if the HTML is rendered on the server. This will only work for Google's search engine, that is able to crawl heavy javascript applications. |
@samvloeberghs thanks again for your comments. I'm aware that the metadata generated by this package is "dynamic" - cannot be indexed any search engines except Google, and also it's not introduced as a replacement of server-side solution to render meta tags. Furthermore, for a complete SEO, other page elements (as well as page contents) should be rendered on the server as well (yeah - angular universal, or prerender.io, phantomjs, etc..). However, this topic refers to webpack bundling of the repo, so I'm closing the issue as it goes off-topic. |
Hi @sambloeverghs, as of v0.2.0-rc.5 it supports server-side rendering. Hope you're still interested in |
Good job!😎 |
No description provided.
The text was updated successfully, but these errors were encountered: