Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production mode build fails when using packages with scss and @import #38

Closed
ahmed-anas opened this issue Jul 21, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@ahmed-anas
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[ ] feature request

Current behavior
using a package like ngx-chips with scss files having @import gives an error unexpected character @ only when building in production mode
Expected/desired behavior
should work

Minimal reproduction of the problem with instructions

  • install ngx-chips view npm install ngx-chips -S
  • include the minimal template in home.component.ts: <tag-input [(ngModel)]='tags'></tag-input>
  • add an tags array to home.component.ts
  • include TagInputModule to home.module.ts from ngx-chips
  • build in prod mode with either npm run build:spa-prod or npm run build:universal-prod

Please tell us about your environment:
vs code, windows 10

  • Browser: all
  • Node (for AoT issues): node --version = 7.8.0
@fulls1z3 fulls1z3 self-assigned this Jul 29, 2017
@fulls1z3 fulls1z3 added the bug label Jul 29, 2017
@fulls1z3 fulls1z3 changed the title bug: production mode build fails when using packages with scss and @import [bug] production mode build fails when using packages with scss and @import Jul 29, 2017
@fulls1z3
Copy link
Owner

@ahmed-anas I'll have a look on this on the first opportunity, and many thanks for your contributions 👍

fulls1z3 pushed a commit that referenced this issue Aug 2, 2017
@fulls1z3
Copy link
Owner

fulls1z3 commented Aug 2, 2017

@ahmed-anas done 👍

@fulls1z3 fulls1z3 closed this as completed Aug 2, 2017
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
* chore(package): update deps

Closes #14
Closes #36
Closes #38
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
* chore(package): update deps

Closes #14
Closes #36
Closes #38
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
* chore(package): update deps

Closes #14
Closes #36
Closes #38
@fulls1z3 fulls1z3 changed the title [bug] production mode build fails when using packages with scss and @import production mode build fails when using packages with scss and @import Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants