Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@nguniversal/express-engine not compatible w/node 8.x #48

Closed
fulls1z3 opened this issue Aug 2, 2017 · 2 comments
Closed

@nguniversal/express-engine not compatible w/node 8.x #48

fulls1z3 opened this issue Aug 2, 2017 · 2 comments
Assignees
@fulls1z3
Labels
bug

Comments

@fulls1z3
Copy link
Owner

fulls1z3 commented Aug 2, 2017

I'm submitting a ... (check one with "x")

[x] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[ ] feature request

Current behavior
The dependency @nguniversal/express-engine does not support node.js v8.x.

Expected/desired behavior
It should support node.js platform v8.x.

Minimal reproduction of the problem with instructions
Running either npm install or yarn results with failure.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 2.0.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =
@fulls1z3 fulls1z3 added the bug label Aug 2, 2017
@fulls1z3
Copy link
Owner Author

fulls1z3 commented Aug 2, 2017 •
edited

There's an open issue and PR on angular/universal repository (angular/universal#758) but the npm package containing the express-engine is not up-to-date.

@fulls1z3
Copy link
Owner Author

fulls1z3 commented Aug 2, 2017 •
edited

@theomathieubhvr I'll need to roll back the PR #31

fulls1z3 pushed a commit that referenced this issue Aug 2, 2017
fix: rollback to ngx-universal/express-engine (#48)
f22c0f4
fulls1z3 pushed a commit that referenced this issue Aug 2, 2017
fix: rollback to ngx-universal/express-engine (#48)
fb5da4b
@fulls1z3 fulls1z3 closed this as completed Aug 2, 2017
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
fix: rollback to `@ngx-universal-express-engine)
b4e07e4 
* build(npm): remove package-lock

* build: update config

* chore(package): update deps

Closes (#48)
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
fix: rollback to `@ngx-universal-express-engine)
1f1c3ac 
* chore(package): update deps

* build(npm): remove package-lock

* build: update config

Closes #48
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
fix: rollback to `@ngx-universal-express-engine)
fa62d11 
* chore(package): update deps

* build(npm): remove package-lock

* build: update config

Closes #48
@fulls1z3 fulls1z3 changed the title [bug] @nguniversal/express-engine is incompatible with node.js 8.x nguniversal/express-engine is incompatible with node.js 8.x Sep 16, 2017
@fulls1z3 fulls1z3 changed the title nguniversal/express-engine is incompatible with node.js 8.x @nguniversal/express-engine not compatible w/node 8.x Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fulls1z3 fulls1z3

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulls1z3 @theomathieubhvr