verifySignature: always use the certificate's algorithm #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerifySignature previously hardcoded x509.SHA1WithRSA as the verification signature. As of Go 1.10, the x509 package verifies that the requested algorithm matches the certificate's public key type. VerifySignature would then fail for certificates with DSA keys, such as AWS's EC2 instance identity documents. Fix this by always using the certificate's algorithm directly.
msiebeling
pushed a commit
to sggms/pkcs7
that referenced
this pull request
Nov 25, 2019
Since Go 1.10, the SignatureAlgorithm is now validated against the public key type. It was "working" before because the Amazon key used DSA with SHA1, and so the RSA/DSA mismatch didn't matter since the SHA1 hash type did. This uses some unexported code from `crypto/x509` that looks up a signature algorithm for a given `pxix.AlgorithmIdentifier` Fixes fullsailor#27 Fixes fullsailor#28 Fixes fullsailor#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerifySignature previously hardcoded x509.SHA1WithRSA as the
verification signature. As of Go 1.10, the x509 package verifies that
the requested algorithm matches the certificate's public key type.
VerifySignature would then fail for certificates with DSA keys, such
as AWS's EC2 instance identity documents.
Fix this by always using the certificate's algorithm directly.