Handle objects that can't be cloned recursively. Fix Ã#93

fullstack-build · Mar 11, 2021 · 030c203 · 030c203
1 parent 6a9e1bf
commit 030c203
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/src/LoggerHelper.ts b/src/LoggerHelper.ts
@@ -294,8 +294,6 @@ export class LoggerHelper {
           return LoggerHelper.cloneObjectRecursively(value, maskValuesFn, done);
         }
       }) as unknown) as T;
-    } else if (Buffer.isBuffer(obj)) {
-      return obj as T;
     } else {
       Object.getOwnPropertyNames(obj).forEach((currentKey: string | number) => {
         if (!done.includes(obj[currentKey])) {

diff --git a/src/LoggerWithoutCallSite.ts b/src/LoggerWithoutCallSite.ts
@@ -893,8 +893,15 @@ export class LoggerWithoutCallSite {
     object: object | null,
     options: InspectOptions
   ): string {
-    const maskedObject = this._maskValuesOfKeys(object);
-    return this._maskAny(inspect(maskedObject, options));
+    let formatted;
+    try {
+      const maskedObject = this._maskValuesOfKeys(object);
+      formatted = format(maskedObject, options);
+    } catch {
+      formatted = format(object, options);
+    }
+
+    return this._maskAny(formatted);
   }
 
   private _formatAndHideSensitive(

diff --git a/tests/parameter.test.ts b/tests/parameter.test.ts
@@ -1,7 +1,7 @@
 import "ts-jest";
 import { IStd, Logger } from "../src";
 import { doesLogContain } from "./helper";
-import exp = require("constants");
+import { URL } from "url";
 
 const stdOut: string[] = [];
 const stdErr: string[] = [];
@@ -135,4 +135,12 @@ describe("Logger: Parameter", () => {
     expect(doesLogContain(stdOut, "SILLY")).toBeTruthy();
     expect(doesLogContain(stdOut, "<Buffer 66 6f 6f>")).toBeTruthy();
   });
+
+  test("Url", (): void => {
+    const url = new URL("http://example.com");
+    logger.silly(url);
+
+    expect(doesLogContain(stdOut, "SILLY")).toBeTruthy();
+    expect(doesLogContain(stdOut, "http://example.com/")).toBeTruthy();
+  });
 });