Merge pull request #43 from fullstack-build/development

Fix: #42: Transport should have own min log level / added test
fullstack-build · Aug 17, 2020 · acabc8f · acabc8f
2 parents 120a7ee + 4f98811
commit acabc8f
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/src/LoggerHelper.ts b/src/LoggerHelper.ts
@@ -106,7 +106,11 @@ export class LoggerHelper {
 
   public static overwriteConsole(
     $this: Logger,
-    handleLog: Function
+    handleLog: (
+      logLevel: TLogLevelName,
+      logArguments: unknown[],
+      exposeStack?: boolean
+    ) => void
   ): ILogObject | void {
     ["log", "debug", "info", "warn", "trace", "error"].forEach(
       (name: string) => {

diff --git a/src/index.ts b/src/index.ts
@@ -372,7 +372,7 @@ export class Logger {
     this._attachedTransports.forEach((transport: ITransportProvider) => {
       if (
         logObject.logLevelId >=
-        Object.values(this._logLevels).indexOf(this.settings.minLevel)
+        Object.values(this._logLevels).indexOf(transport.minLevel)
       ) {
         transport.transportLogger[logLevel](logObject);
       }

diff --git a/tests/transport.test.ts b/tests/transport.test.ts
@@ -67,4 +67,21 @@ describe("Logger: Transport", () => {
       doesLogContain(stdErr, transportErr[0].argumentsArray[0] as string)
     ).toBeTruthy();
   });
+
+  test("different log level", (): void => {
+    logger.setSettings({ minLevel: "info" });
+
+    logger.silly("test message");
+    logger.trace("test message");
+    logger.debug("test message");
+    logger.info("test message");
+    logger.warn("test message");
+    logger.error("test message");
+    logger.fatal("test message");
+
+    // all 4: silly, trace, debug, info
+    expect(transportOut.length).toBe(4);
+    // info only to stdOut
+    expect(stdOut.length).toBe(1);
+  });
 });