Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Cannot convert undefined or null to object #78

Closed
flybayer opened this issue Dec 31, 2020 · 3 comments
Closed

Bug: Cannot convert undefined or null to object #78

flybayer opened this issue Dec 31, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@flybayer
Copy link

Describe the bug

These both fail as of 3.0.3. They worked fine in 2.9.1

To Reproduce

logger.info("A", null)
logger.info("B", undefined)

Expected behavior
Logger should accept all values, especially null and undefined.

Node.js Version
12

OS incl. Version
System:
OS: macOS 11.1
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Memory: 1.43 GB / 64.00 GB
Shell: 3.1.2 - /usr/local/bin/fish
@flybayer flybayer added the bug Something isn't working label Dec 31, 2020
@terehov
Copy link
Contributor

terehov commented Jan 2, 2021

Thank you very much. A bugfix is coming soon.

@terehov terehov closed this as completed in 1cd0dbc Jan 2, 2021
terehov added a commit that referenced this issue Jan 2, 2021
@terehov
Merge pull request #79 from fullstack-build/development
20a9674 
Fix #78: Allow null and undefined parameters again
@terehov
Copy link
Contributor

terehov commented Jan 2, 2021

Fixed:

https://github.com/fullstack-build/tslog/releases/tag/v3.0.5

@flybayer
Copy link
Author

flybayer commented Jan 2, 2021

Thank you!

This was referenced Mar 12, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump tslog from 2.12.0 to 3.1.2 hobigo/nextcloud-node-client
2 participants
@terehov @flybayer