Fix FSHApiConventions #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iammukeshm
reviewed
Jan 16, 2022
| @@ -45,7 +45,7 @@ public Task<string> GenerateRandomAsync(GenerateRandomBrandRequest request) | |||
| } | |||
|
|
|||
| [HttpDelete("delete-random")] | |||
| [ApiConventionMethod(typeof(FSHApiConventions), nameof(FSHApiConventions.Delete))] | |||
| [ApiConventionMethod(typeof(FSHApiConventions), nameof(FSHApiConventions.Search))] | |||
There was a problem hiding this comment.
The problem is that you can't use a method in that attribute that has multiple overloads... and search is one that doesn't have multiple overloads...
There was a problem hiding this comment.
At this point it doesn't really matter as they all have the same attributes... but eventually we will probably want to clean this out and put the right responsecodes on the right kind of methods...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the api's didn't have the ProducesResponseType attributes anymore due to adding cancellationtokens.
This pr fixes that... also fixes fullstackhero/blazor-wasm-boilerplate#81... will need an fshapi update there though...