-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded Support for Non-Default ID Type in AuditableEntitiesByCreatedOnBetweenSpec #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly typed errors instead of DbUpdateException
Feat push notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation has a limitation regarding the use of the AuiditableEntitiesByCreatedOnBetweenSpec with entities that have a defined non-default ID type.
Previously, if we defined an entity, such as Payment, with the default ID type, like so:
it was perfectly possible to utilize
AuditableEntitiesByCreatedOnBetweenSpec<Payment>
.However, when we add a specific ID type to the
AuditableEntity
, the compatibility changes.In this format, we previously couldn't use
AuditableEntitiesByCreatedOnBetweenSpec<Payment>
due to the fact thatAuditableEntity
andAuditableEntity<int>
are considered different types.With the changes introduced in this pull request, the boilerplate now extends its support to non-default ID types within
AuditableEntity
.Now the
AuditableEntitiesByCreatedOnBetweenSpec
can be used likeAuditableEntitiesByCreatedOnBetweenSpec<Payment, int>
for AuditableEntities that do not have default ID types.