Update Part 3c Mongo Cluster Onboarding #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mongo onboarding documentation and mongoose code sample. Mongo UI flow changed, so updating that just to be up-to-date. I followed the steps in the course as best I could and I got admin database as my given SRV string not test, so adding an important NB to save people time from this frustrating new change. Adding useUnifiedTopology fixes a deprecation error (discussed at Automattic/mongoose#8156 ). Handling/resolving promises eliminates deprecation warnings in the code.
|
great improvements, however I can not merge quite yet since .finally is not currently covered in text. |
Don't use finally in the code sample because it hasn't yet been covered in the text.
|
@mluukkai I've removed the use of |
|
Pull request has conflicts, so closing it now. If needed, PR can be reopened after conflicts are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mongo onboarding steps and mongoose code sample
useUnifiedTopologyto fix a deprecation error discussed at DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor. Automattic/mongoose#8156