Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected some lint issues, and got Karma and all mocha tests passing #5

Merged
merged 2 commits into from
Aug 15, 2016

Conversation

chris-house
Copy link
Contributor

I fixed a few of the tslint error messages in hopes to get karma up and running.

@chris-house
Copy link
Contributor Author

Also fixed karma and the mocha test!!!

@chris-house chris-house changed the title chore: tslint cleanup fix: fixed some lint issues, and got Karma and all mocha tests passing Aug 15, 2016
@chris-house chris-house changed the title fix: fixed some lint issues, and got Karma and all mocha tests passing fix: corrected some lint issues, and got Karma and all mocha tests passing Aug 15, 2016
@chris-house chris-house mentioned this pull request Aug 15, 2016
@chris-house
Copy link
Contributor Author

chris-house commented Aug 15, 2016

To run the tests, you need to run karma start. not npm run. this is still broken due to #6 (lint failing)

@chris-house
Copy link
Contributor Author

I have added a chat room on gitter for this repo so it is easier to chat. https://gitter.im/aspnetcorespa/Lobby?utm_source=share-link&utm_medium=link&utm_campaign=share-link

@asadsahi asadsahi merged commit 3edb776 into fullstackproltd:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants