-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document "well known" protobuf types and their json mapping #121
Comments
This is standard JSON encoding for protocol buffers, which is already documented here: https://developers.google.com/protocol-buffers/docs/proto3#json |
got into same issue, and found solution only because of this thread |
I want to add that I also think this should be documented explictly. Also, this would be nice if we could deactivate the mapping. I am trying to write a e2e testing script that use grpcurl output to make assertions, but it is made difficult by the fact I have to use the formatted messages instead of the json |
Another day another encounter this :D Thanks @jhump for pointing JSON spec. |
I struggled to form the json payload for a gRPC service that used google's well-known timestamp defintion. I assumed the json for it would be:
Only by trial and error, did I figure out that
grpcurl
actually expects the timestamp to be an RFC string:I think this behavior (along with any other non-trivial mappings) should be documented on the README. I'm happy to make the PR for these additions, but I don't know where to find this mapping.
Thanks!
The text was updated successfully, but these errors were encountered: