Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add class names to relevant components for better css targeting #593

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jonathanwilke
Copy link

To enable custom styling of certain elements it is necessary to be able to target certain components and elements with CSS. Therefore we need to have uniqe classes or ids on these elements.

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 6a1f77f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
fumadocs-ui Patch
fumadocs-core Patch
create-fumadocs-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 11, 2024

@jonathanwilke is attempting to deploy a commit to the Fuma Team on Vercel.

A member of the Team first needs to authorize it.

@fuma-nama
Copy link
Owner

Considering we have Tailwind CSS enabled in the project, I think it's better to use data-xxx instead of a class name, like data-theme-toggle for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants