-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to build with Devcontainer #88
Conversation
.env.example
Outdated
@@ -42,3 +42,10 @@ PUSHER_APP_CLUSTER=mt1 | |||
|
|||
GOOGLE_CLIENT_ID=104771318401-qthv7ou0a07bg2f4osotih40n5ituohh.apps.googleusercontent.com | |||
GOOGLE_CLIENT_SECRET=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 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These would be needed to be set if used within Docker if you want to use Ray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we:
- move
ray.go
to.devcontainer/
- add to the readme on how to use this
- specify in the readme to move
ray.go
to/
to use ray+docker
.devcontainer/README.md
Outdated
@@ -0,0 +1,36 @@ | |||
To use within Dev Container you need to make sure your `.env` is using the proper configuration. The you can open VS Code in Remote Container. This will build the app and configure your database and tools like Mailhog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start with ## Docker dev container support
s/The/Then
.devcontainer/README.md
Outdated
MAIL_FROM_NAME="${APP_NAME}" | ||
``` | ||
|
||
If you need to use tools like Ray, you can copy this `ray.php` file and move to the root of your project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/and move//
No description provided.