Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to build with Devcontainer #88

Merged
merged 9 commits into from
Aug 10, 2022

Conversation

tcampbPPU
Copy link
Member

No description provided.

.env.example Outdated
@@ -42,3 +42,10 @@ PUSHER_APP_CLUSTER=mt1

GOOGLE_CLIENT_ID=104771318401-qthv7ou0a07bg2f4osotih40n5ituohh.apps.googleusercontent.com
GOOGLE_CLIENT_SECRET=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

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These would be needed to be set if used within Docker if you want to use Ray

@tcampbPPU tcampbPPU mentioned this pull request Aug 10, 2022
Copy link
Member

@acidjazz acidjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we:

  • move ray.go to .devcontainer/
  • add to the readme on how to use this
  • specify in the readme to move ray.go to / to use ray+docker

@@ -0,0 +1,36 @@
To use within Dev Container you need to make sure your `.env` is using the proper configuration. The you can open VS Code in Remote Container. This will build the app and configure your database and tools like Mailhog.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start with ## Docker dev container support

s/The/Then

MAIL_FROM_NAME="${APP_NAME}"
```

If you need to use tools like Ray, you can copy this `ray.php` file and move to the root of your project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/and move//

@acidjazz acidjazz merged commit d4a98b6 into fumeapp:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants