Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect *.import from .gitignore as it breaks plugin & add missing *.import files #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Feb 18, 2020

  1. Remove incorrect *.import from .gitignore as it breaks plugin.

    NOTE: This is part 1 of a 2 part fix.
    
    If the plugin does not contain the image-related `*.import` files
    then the plugin fails to load the first time project is opened.
    
    See here for "official" Godot `.gitignore` file: <https://github.com/github/gitignore/blob/master/Godot.gitignore>
    
    The error on opening is (in a dialog box):
    
        Unable to load addon script from path: 'res://addons/godot-camera-plugin.funabab/plugin.gd' There seems to be an error in the code, please check the syntax.
    
    But the underlying error (in the Output console) is:
    
        No loader found for resource: res://addons/godot-camera-plugin.funabab/icon_camera.png.
        res://addons/godot-camera-plugin.funabab/camera_view.gd:6 - Parse Error: Can't preload resource at path: res://addons/godot-camera-plugin.funabab/icon_camera.png
    
    For additional context, see: <https://old.reddit.com/r/godot/comments/f4uhpk/i_get_stuck_with_android_plugin/>
    follower committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    2cbfbd9 View commit details
    Browse the repository at this point in the history
  2. Add missing .import files for plugin images.

    NOTE: This is part 2 of a 2 part fix.
    
    If the plugin does not contain the image-related `*.import` files
    then the plugin fails to load the first time project is opened.
    
    See here for "official" Godot `.gitignore` file: <https://github.com/github/gitignore/blob/master/Godot.gitignore>
    
    The error on opening is (in a dialog box):
    
        Unable to load addon script from path: 'res://addons/godot-camera-plugin.funabab/plugin.gd' There seems to be an error in the code, please check the syntax.
    
    But the underlying error (in the Output console) is:
    
        No loader found for resource: res://addons/godot-camera-plugin.funabab/icon_camera.png.
        res://addons/godot-camera-plugin.funabab/camera_view.gd:6 - Parse Error: Can't preload resource at path: res://addons/godot-camera-plugin.funabab/icon_camera.png
    
    For additional context, see: <https://old.reddit.com/r/godot/comments/f4uhpk/i_get_stuck_with_android_plugin/>
    follower committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    3dbf029 View commit details
    Browse the repository at this point in the history