Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little visual glitch or intended (dark themes)? #52

Closed
klaus101 opened this issue Mar 14, 2023 · 11 comments
Closed

Little visual glitch or intended (dark themes)? #52

klaus101 opened this issue Mar 14, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@klaus101
Copy link

Describe the bug
I'm just trying this explorer plugin fork and would like to ask about three things. I really hope i don't bother!
The first is a little visual glitch (at least at appears to me; but maybe it's intended or i'm in error):
See image: the button representing opening a dropdown - upper right corner - and as well the splitter.
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
1.Set NPP dark mode; (within Settings > preferenes)
2. Settings > Style Configurator -> try any dark theme
3. Check the color of button (upper right corner) and splitter

Expected behavior
Button and splitter colors should look consistent with the theme, Actually for me they don't (appear white).
Is it inteneded? Or did i simply do an error?

Screenshots
If applicable, add screenshots to help explain your problem.
glitch

Debug Info
Notepad++ v8.5 (64-bit)
Build time : Mar 6 2023 - 02:18:13
Path : D:\Test\NPP\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Home (64-bit)
OS Version : 22H2
OS Build : 19045.2673
Current ANSI codepage : 1252
Plugins :
Explorer (1.8.2.18)
mimeTools (2.9)
NppConverter (4.5)
NppExport (0.4)
NPPJSONViewer (2.0.4)


**Additional context**
The funap explorer plugin is the x64 version.  NPP is 8.5 x64 the portable version
@funap
Copy link
Owner

funap commented Mar 14, 2023

@klaus101
Thank you for contacting me!
The dark mode is Notepad++ drawing the controls, but some of them seem to be incomplete.
I will try to find out if it can be improved from the plugin side.

@funap funap added the bug Something isn't working label Apr 18, 2023
@funap funap self-assigned this Apr 18, 2023
@funap
Copy link
Owner

funap commented May 2, 2023

This problem has been fixed in ver 1.8.2.20.

@funap funap closed this as completed May 2, 2023
@klaus101
Copy link
Author

klaus101 commented May 2, 2023

Thank you a lot funap for your fix! It's basically corrected now ... with the little caveat that the refresh button in the upper right corner is hard to recognize (i know such is a challenge with the dark themes).
refresh_button

A part of the change is that - for the file list view - the selection color did change to a more usual and better looking blue.
But the unfocused color now is white. I'd guess that had not been intended.

1.8.2.19 - left: selected focused right: selected unfocused:
selecteed_unfocused_1 8 2-19

1.8.2.20 - left: selected focused right: selected unfocused:
selecteed_unfocused_1 8 2-20

@klaus101
Copy link
Author

klaus101 commented May 2, 2023

Oh ... and the file listview's hovering color (mouseover color) disappeared with the 1.8.20, that's not so good.

@funap funap reopened this May 2, 2023
@funap
Copy link
Owner

funap commented May 2, 2023

Hi @klaus101
Thanks for your report!!
I was checking on Windows 11. I thought it was displaying well.

win11_listview_dark

But, I understand that there is a problem when running on Windows 10.
This Issue will remain Open until the issue is resolved.

@klaus101
Copy link
Author

klaus101 commented May 2, 2023

Differences here between win10 and win11 ... - oh no :-(

ListView, Win 10 / 1.8.2.19 for me looked quite good.
win10x64_1 8 2 19

With 1.8.2.20 the selecton color appeared a bit nicer and a oftenly chosen color, but the "unfocusing" and "hovering" behaviour is a caveat. Strange that is is so different between win10 and 11.
win10x64_1 8 2 20

@funap
Copy link
Owner

funap commented May 2, 2023

@klaus101
Thank you very much!
I really understand! :)

I will fix to be independent of OS version.

@klaus101
Copy link
Author

klaus101 commented May 2, 2023

Hi funap, thank yoo!
This OS differerence is a bad surprise i guess.

Btw for to avoid confusion: just noticed that my NPP theme file used here was not "DarkModeDefault", sorry. Repeated the test with "DarkModeDfault", but bvasically it's the same. Just as expected.

@funap
Copy link
Owner

funap commented May 3, 2023

v1.8.2.21 has been released.
List view changes in 1.8.2.20 have been revert.

@klaus101
Copy link
Author

klaus101 commented May 3, 2023

Ok, on Win10 for the listview (and treeview) it's back to the appearances as of the 1.8.2.19, which is qhite good imo.

The two little glitches mentioned in the OP (concerning refresh button, and splitter) are fixed. The refresh button is a bit hard to recognize, but ok, it's not really a problem.
So i think this can be closed .... Thank you very much funap for your efforts!

@klaus101 klaus101 closed this as completed May 3, 2023
@funap
Copy link
Owner

funap commented May 3, 2023

You’re very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants