Merge pull request #30 from funbox/bugfix/get-start-of-month

Fix setDate before setMonth

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 5.0.1 (04.04.2023)
+
+Fixed `getStartOfMonth` which returned wrong value when the second argument is passed 
+and the difference between the current and the desired month is not equal to 0.
+
+
 ## 5.0.0 (27.01.2023)
 
 Added alternative functions to deal with both full and calendar days, months, years.

lib/getStartOfMonth.ts

@@ -9,11 +9,12 @@ import { ChronosDate, ensureDate } from './helpers/ensureDate';
 export default (value: ChronosDate, diff = 0): Date => {
   const date = ensureDate(value);
 
+  date.setDate(1);
+
   if (diff) {
     date.setMonth(date.getMonth() + diff);
   }
 
-  date.setDate(1);
   date.setHours(0, 0, 0, 0);
 
   return date;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@funboxteam/chronos",
-  "version": "5.0.0",
+  "version": "5.0.1",
   "description": "One library to rule the time",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

tests/index.ts

@@ -527,6 +527,10 @@ describe('getStartOfMinutes, getStartOfHours, getStartOfDay, getStartOfWeek, get
     expect(getStartOfMonth(new Date(2020, 2, 2, 23, 59), -1)).to.equalTime(new Date(2020, 1, 1, 0, 0));
   });
 
+  it('returns date of start of month - 1', () => {
+    expect(getStartOfMonth(new Date(2023, 2, 31, 23, 59), -1)).to.equalTime(new Date(2023, 1, 1, 0, 0));
+  });
+
   it('returns date of start of year', () => {
     expect(getStartOfYear(new Date(2020, 1, 1, 23, 59))).to.equalTime(new Date(2020, 0, 1, 0, 0));
   });