Support arrays in objectToQueryString #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdnsk
commented
Feb 18, 2021
| return acc.concat(value.map((item) => `${key}=${encodeURIComponent(item)}`)); | ||
| } | ||
|
|
||
| return acc.concat(`${key}=${encodeURIComponent(value)}`); |
There was a problem hiding this comment.
I decided to use Array.concat instead of spread operator to prevent adding of polyfills.
343dev
approved these changes
Feb 18, 2021
igoradamenko
force-pushed
the
array-in-query-string
branch
from
cc9a12c
to
af21a56
Compare
igoradamenko
approved these changes
Feb 19, 2021
|
Published @funboxteam/diamonds@8.1.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of arrays in passed objects.
{'foo': ['bar', 'baz']}converts tofoo=bar&foo=baz.