Fix string to number short conversion

[dshster]

No description provided.

[igoradamenko]

Not sure that I've got the idea behind this change.

The comment above was saying what was going on here. The comment hasn't been changed, so I assume that there was an error, but not the line is fully “in accordance” with the comment.

Then, I'm testing the change:

const num = 17.0001;

console.log((+num.toFixed(2)).toString()); // '17'

console.log((+num).toFixed(2)); // '17.00'

The current implementation does not remove trailing zeros, while the comment says it should.

If the idea was to change the actual behavior, then it's better to add a flag or something, because there are users who rely on the current behavior. So it should not be changed, I believe.

[leusrox]

Judging by the README, it should be possible to pass a string: https://github.com/funbox/diamonds/blob/master/README.md#:~:text=Formats%20a%20number%20(-,or%20a%20string%20with%20a%20number%20inside,-)%20using%20the%20passed

Passing the string leads to an error, so I think we need to fix the README or change the behavior for string values only.

[igoradamenko]

@leusrox, ah, I see.

I'd rather believe types, than README.

I think that this part in README was simply copy-pasted from formatPhoneNumberString description. But we are free to change the helpers to make them allow strings:

#41

[leusrox]

Thanks!