Improve README #25
Merged
Improve README #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoradamenko
force-pushed
the
improvement/readme
branch
from
9516c79
to
b50a13f
Compare
igoradamenko
commented
Jul 27, 2020
| @@ -170,10 +233,12 @@ end | |||
| ``` | |||
|
|
|||
| ### Хелперы | |||
| Подключение хелперов в класс позволяет использовать методы логирования `log_info` и `log_error`, | |||
|
|
|||
| Подключение хэлперов в класс позволяет использовать методы логирования `log_info` и `log_error`, | |||
There was a problem hiding this comment.
Смущает, что нет перечисления всех этих хэлперов. Но может я не понимаю, что тут вообще подразумевается под хэлперами.
Просто ниже есть:
с хэлпером
log_optionsнеобходимо использовать
Что подразумевает, что их несколько. Но я так и не понял, какие есть. Вроде бы только про log_info и log_error написано.
There was a problem hiding this comment.
Имеется в виду подключение модуля хелперов Loggun::Helpers.
В этом модуле на данный момент всего один хелпер log_options и набор методов вида log_<severity>.
igoradamenko
commented
Jul 27, 2020
igoradamenko
commented
Jul 27, 2020
igoradamenko
force-pushed
the
improvement/readme
branch
from
b50a13f
to
623585e
Compare
igoradamenko
force-pushed
the
improvement/readme
branch
from
623585e
to
6c2da28
Compare
nemestny
approved these changes
Jul 28, 2020
| @@ -170,10 +233,12 @@ end | |||
| ``` | |||
|
|
|||
| ### Хелперы | |||
| Подключение хелперов в класс позволяет использовать методы логирования `log_info` и `log_error`, | |||
|
|
|||
| Подключение хэлперов в класс позволяет использовать методы логирования `log_info` и `log_error`, | |||
There was a problem hiding this comment.
Имеется в виду подключение модуля хелперов Loggun::Helpers.
В этом модуле на данный момент всего один хелпер log_options и набор методов вида log_<severity>.
QNester
approved these changes
Jul 28, 2020
QNester
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.