Update Crafter, drop Node.js 12 support, move to Node.js 18 #15
Conversation
|
@Ge11ert, eh, feels like one does not simply update Crafter, does they? https://github.com/funbox/vscode-apib-ls/actions/runs/5210878143/jobs/9402497422 |
No preliminary thoughts, to be honest. Will look into it |
| @@ -76,7 +76,7 @@ | |||
| "scripts": { | |||
| "vscode:prepublish": "npm run clean-dist-dir && npm run esbuild-min", | |||
| "clean-dist-dir": "rm -rf dist/", | |||
| "esbuild-base": "esbuild ./client/extension.js ./server/server.js --bundle --outdir=dist --define:process.env.BASE_DIR='\"dist\"' --external:vscode --format=cjs --platform=node", | |||
| "esbuild-base": "esbuild ./client/extension.js ./server/server.js --bundle --outdir=dist --define:process.env.BASE_DIR='\"dist\"' --external:vscode --format=cjs --platform=node --target=es2018", | |||
There was a problem hiding this comment.
@igoradamenko The Empire Crafter did nothing wrong.
I've tried to update some packages and run vscode-test/sample using different versions of Node, but no luck. Then I managed to find out the original crash error.
Here is the trick:
- server part of our extension includes vscode-languageserver
- it includes vscode-languageserver-protocol
- it includes vscode-jsonrpc
vscode-jsonrpc itself includes some relatively fresh ES features like optional chaining: https://github.com/microsoft/vscode-languageserver-node/blob/main/jsonrpc/src/common/linkedMap.ts#L59
So the error was
vscode-apib-ls/dist/server/server.js:320
return this._head?.value;
^
SyntaxError: Unexpected token '.'
Since we use relatively old version of VScode in our tests (1.48), I guess that Electron wrapper of that version contains slightly outdated chromium, which does not support optional chaining.
Now, esbuild doc says:
by default, esbuild's output will take advantage of all modern JS features. For example, a !== void 0 && a !== null ? a : b will become a ?? b when minifying is enabled which makes use of syntax from the ES2020 version of JavaScript.
Since I don't want to force users to use brand new VSCode versions, I set target ES version for esbuild to ES2018, so it can transpile optional chaining and other js features.
As you see, now tests are green =)
There was a problem hiding this comment.
Ah, sweet taste of ES syntactic sugar! Yummm.
Thank you for the research and the fix 🤝
|
Sent the release archive into VSCode Marketplace:
Will be published within an hour, I think. |
No description provided.