Add ability to construct PrivateKey from string #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Thanks! |
niwinz
added a commit
that referenced
this pull request
Dec 9, 2015
Add ability to construct PrivateKey from string
|
Glad to help. Obviously relying on the foundation you already have in place made it much easier to accomplish! |
|
Hello nlwinz. Sorry to ask, but do you have a timeframe of when you're going to create a new release with these updates? We could create artifacts locally but it would be better if thy came from an official repo if possible. Thanks! |
|
I will release it today. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project where I am generating private keys as strings but don't write them to files.
For this, I added a variable arity keys/str->private-key function to construct PrivateKey objects similar to the existing keys/str->public-key functions that create PublicKey objects.
Comments welcome!