Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadZero for either? #118

Closed
muhuk opened this issue Oct 27, 2015 · 6 comments
Closed

MonadZero for either? #118

muhuk opened this issue Oct 27, 2015 · 6 comments

Comments

@muhuk
Copy link
Contributor

muhuk commented Oct 27, 2015

Is there a reason either doesn't have a MonadZero implementation?

Haskell's Either seems to have one.

If there are obstacles, I can perhaps pick this up. Just wanted to confirm it can be supported and you might be willing to merge a PR.
@ghost
Copy link

ghost commented Oct 27, 2015

Feel free to submit a patch, looks like we missed that one. Thanks in advance!

@yurrriq
Copy link
Collaborator

yurrriq commented Oct 27, 2015

I've made a first pass. It needs review and preferably tests.

PS I noticed there are no tests for mzero or mplus. We should probably remedy that.

$ ag mzero test; or echo "No mzero tests!"
No mzero tests!
$ ag mplus test; or echo "No mplus tests!"
No mplus tests!

@yurrriq yurrriq mentioned this issue Oct 27, 2015
Merged
@muhuk
Copy link
Contributor Author

muhuk commented Oct 29, 2015

Thanks @yurrriq.

I'm closing this since it's merged now.

@muhuk muhuk closed this as completed Oct 29, 2015
@muhuk
Copy link
Contributor Author

muhuk commented Oct 29, 2015

I don't suppose 1.1.0-SNAPSHOT contains this. Could you possibly make a new snapshot/release?

@niwinz
Copy link
Member

niwinz commented Oct 29, 2015

Done!

@muhuk
Copy link
Contributor Author

muhuk commented Oct 29, 2015

Thanks, much appreciated.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@muhuk @niwinz @yurrriq