feat: native functions bundle imports #273
Conversation
✅ Deploy Preview for effortless-malabi-1c3e77 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: github-actions <github-actions@github.com>
|
18k lines added? |
snapshotting the serialized bundle? Cool, makes a lot of sense. |
|
100% much easier to see. can't wait to make those smaller. Plus I need to bypass your new lines commit metrics. ;-) |
I think this is completed right? PR ready to merge? Have you looked into why netlify is failing to build? |
Upgrade some dependencies, re-arrange yarn.lock ;) |
test/serialize.test.ts
Outdated
| // In that case increase explicitly. | ||
| const BUNDLED_MAX_SIZE = 500 * 1024; |
There was a problem hiding this comment.
Is this excessive? I know we will slowly improve this over time, but 500KB seems excessive for the tests I see below.
There was a problem hiding this comment.
Can lower it, was arbitrary
There was a problem hiding this comment.
lowered to 50k with the Aaios test using 500k as it is 300k bundled.
There was a problem hiding this comment.
Axios is 300k bundled? gah-dam
Fixes #269, Fixes #264
deploymentOnlyModuleto move files to force the closure serialize to serialize the functionless code instead of importing. Importing Functionless can cause a large number of unnecessary imports to be bundled.