fix: appsync and step function visitor hoist refactor #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effortless-malabi-1c3e77 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thantos
changed the title
15 tasks
sam-goodwin
reviewed
Jun 19, 2022
added 10 commits
June 19, 2022 21:41
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
sam-goodwin
reviewed
Jun 20, 2022
added 7 commits
June 20, 2022 01:06
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
added 2 commits
June 20, 2022 03:38
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
sam-goodwin
reviewed
Jun 20, 2022
src/asl.ts
Outdated
Comment on lines
902
to
862
| return taskState; | ||
| throw Error(""); |
There was a problem hiding this comment.
What should error message be? Why did the logic change?
There was a problem hiding this comment.
got rid of findIntegration which will align better with validating and handling the async change. Will fix error.
sam-goodwin
reviewed
Jun 20, 2022
| */ | ||
| public generateOrGet(node: FunctionlessNode): string { | ||
| if (!this.generatedNames.has(node)) { | ||
| this.generatedNames.set(node, `${this.generatedNames.size}_tmp`); |
There was a problem hiding this comment.
Look at who is using mutability ;)
There was a problem hiding this comment.
I copied your code ;-) but in this case the risk seemed low in a small isolated private methods.
There was a problem hiding this comment.
I copied your code ;-)
Loool
src/visit.ts
Outdated
| ): BlockStmt { | ||
| return visitEachChild(block, (stmt) => { | ||
| const nestedTasks: FunctionlessNode[] = []; | ||
| function hoist(expr: Expr): Expr { |
There was a problem hiding this comment.
Should the return type be an Identifier?
There was a problem hiding this comment.
ohh, yeah, it could be, it was more complex at one point.
| /** | ||
| * Like {@link visitEachChild} but it only visits the statements of a block. | ||
| * | ||
| * Provides the hoist function that allows hoisting expressions into variable statements above the current statement. |
There was a problem hiding this comment.
Pretty nice I must say. Neat.
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
…ionless into appsync_visit
Signed-off-by: github-actions <github-actions@github.com>
3 tasks
sam-goodwin
approved these changes
Jun 20, 2022
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212
Refactor step functions and app sync interpreters to refactor nested tasks to a normal form. This change will make the #202 easier by providing a generic interface for re-writing the AST tree. Async introduces more complex statements that need to be hoisted to a-normal form which would have been previously difficult.