Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support workspace mechanic source directories #240

Closed
akronenw opened this issue Jan 30, 2023 · 2 comments
Closed

Support workspace mechanic source directories #240

akronenw opened this issue Jan 30, 2023 · 2 comments
Labels
enhancement pull-request-welcome
Milestone
1.15.4

Comments

@akronenw
Copy link

In our company we have the workspace mechanic settings files stored on a network directory. In the local mechanic epf file we refer to that directory:
/instance/com.google.eclipse.mechanic/mechanicSourceDirectories=["/path/to/network/directory/mechanic/settings","/user/home/.eclipse/mechanic"]

In order to have the settings automatically collected, the code formatter must support the key and collect all information from that directory. I have already started coding that and can offer a PR soon (I made this issue anyway, for discussions beforehand).
@funfried
Copy link
Owner

Hi @akronenw,

I'm not 100% sure what you exactly need, but if you provide a PR I'm happy to look into it and merge it to the next plugin version. Please keep in mind to create the PR against the branch "release/1.15.x" and NOT master.

Cheers,
Fabi

@funfried funfried added this to the 1.15.4 milestone Jan 30, 2023
akronenw pushed a commit to akronenw/externalcodeformatter_for_netbeans that referenced this issue Feb 3, 2023
Issue funfried#240 - Support workspace mechanic source directories
ed056e0 
Added dedicated workspace mechanic config parser that can read properties from multiple files
@akronenw akronenw mentioned this issue Feb 3, 2023
Merged
funfried added a commit that referenced this issue Mar 7, 2023
@funfried
Merge pull request #241 from akronenw/feature/support_multiple_worksp…
c6b2a6c 
…ace_mechanic_files

Issue #240 - Support workspace mechanic source directories
funfried added a commit that referenced this issue Aug 10, 2023
@funfried
#240 Some cosmetics to contributed workspace mechanic code
5435067
funfried added a commit that referenced this issue Aug 10, 2023
@funfried
#240
254d08c 
Fixed workspace mechanic config parser for Windows
funfried added a commit that referenced this issue Aug 10, 2023
@funfried
#240
1987719 
Fixed workspace mechanic config parser for Windows
funfried added a commit that referenced this issue Aug 11, 2023
@funfried
#240
78d14d5 
Improved workspace mechanic config parsing as it did not work for Windows
funfried added a commit that referenced this issue Aug 15, 2023
@funfried
#240
9a78390 
Added some debug statements to better understand why the tests are failing under Windows
funfried added a commit that referenced this issue Aug 15, 2023
@funfried
#240
cd3de77 
Removed canRead check (may not work under Windows?)
funfried added a commit that referenced this issue Aug 15, 2023
@funfried
#240
9a25976 
Added even more debugging messages
funfried added a commit that referenced this issue Aug 15, 2023
@funfried
#240
ac83651 
Fix handling Windows reference paths in workspace mechanice files
funfried added a commit that referenced this issue Aug 15, 2023
@funfried
#240
b64eb37 
Windows reference path has to be escaped inside the workspace mechanic file, otherwise Java cannot parse it
@funfried
Copy link
Owner

@akronenw Should be done, mostly thanks to your PR and will be published within the next release but is already available within the current SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement pull-request-welcome
Projects
None yet
Milestone
1.15.4
Development

No branches or pull requests
2 participants
@funfried @akronenw