New close actions are not working #17
Comments
XCame
pushed a commit
to XCame/nb-editor-close-left-right
that referenced
this issue
Jul 17, 2023
The problem was, that later checks returning false for isModified() would overwrite earlier "true"s. e.g. if gitModified was true, svnModified was null and hgModified was false, the file would be closed because of the hgModified false passed (hgModified != null && !hgModified) and closed the file although gitModified was true. Signed-off-by: Fabian Kreuzkam <fabian@kreuzkam.com>
|
Good afternoon. The changes don't work, at least with Subversion. There are tabs that have not been changed in VSC (the black color of the tab text) and changed (the blue color of the tab text), the plugin closes all files (including blue ones, although they are not marked). Do I understand the implemented functionality correctly, that it shouldn't be like this? Thanks! |
|
Yes, true, I added a bug there and there is already a PR from @XCame but I couldn't merge it yet, I will publish a bug fix release within the next days. Stay tuned. Cheers, |
funfried
added a commit
that referenced
this issue
Aug 7, 2023
|
Should be fixed in the current SNAPSHOT version and therefore within the up coming release. |
|
Checked at work. So far, at least. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems the new project related close actions as well as the VCS related close action are not working correctly. The VCS close action just closes every tab and the project related actions seem to close too many tabs.
The text was updated successfully, but these errors were encountered: