Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Close Left" closes everything #32

Closed
jkovalsky opened this issue Mar 15, 2024 · 2 comments
Closed

"Close Left" closes everything #32

jkovalsky opened this issue Mar 15, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@jkovalsky
Copy link

The nb-editor-close-left-right-1.0.5.nbm does not work as expected. I don't see any Close Right action, and Close Left closes all opened tabs instead of just the desired ones. Tested in:

Product Version: Apache NetBeans IDE 19
Java: 19.0.2; OpenJDK 64-Bit Server VM 19.0.2+7-44
Runtime: OpenJDK Runtime Environment 19.0.2+7-44
System: Linux version 5.15.0-100-generic running on amd64; UTF-8; cs_CZ (nb)

@funfried
Copy link
Owner

Hi @jkovalsky,

First of all thanks for testing! Sounds weird to me as the plugin seems to work in the latest version and I tested it even with NetBeans 12, but I'll have a look at it myself and see what I can do to make it work in NetBeans 19 again.

Cheers,
Fabian

@funfried funfried added this to the 1.0.6 milestone Mar 18, 2024
@funfried funfried self-assigned this Mar 18, 2024
@funfried funfried added the bug label Mar 18, 2024
funfried added a commit that referenced this issue Mar 19, 2024
Factories are now the service providers which are creating the actions instead of registering the actions as service providers
@funfried
Copy link
Owner

Hi @jkovalsky,

I checked and I'm pretty sure this bug is not related to a special NetBeans version, it seems to be a general issue with that version. I think I found a solution for this issue and will provide a fixed version soon.

Thanks for testing my plugin and for your work at the NetBeans plugin center! And sorry for obviously not testing it myself as good as I should.

Cheers,
Fabian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants