Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PING PONG #9

Closed
kappsegla opened this issue Feb 2, 2023 · 0 comments · Fixed by #94
Closed

PING PONG #9

kappsegla opened this issue Feb 2, 2023 · 0 comments · Fixed by #94
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kappsegla
Copy link
Contributor

To test out our connection

We can send a PING with an optional message to our server to verify that we have a working connection, that the server response isn't an error and can also be used for measuring latency.
Could also be a good smoke test to run to verify that we can produce and run a working server? Create separate issue for this.

When client sends a ping without a message
PING\r\n

the server should reply with a simple string
+PONG\r\n

If a message is included the response should be a bulk string.
PING hello\r\n
"$5\r\nhello\r\n"

@kappsegla kappsegla added the enhancement New feature or request label Feb 2, 2023
@Lugn1 Lugn1 self-assigned this Feb 8, 2023
@kappsegla kappsegla added this to the 2 milestone Feb 12, 2023
@Lugn1 Lugn1 linked a pull request Feb 13, 2023 that will close this issue
kappsegla added a commit that referenced this issue Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants