Add delete feature #102
Merged
Add delete feature #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jLereback
requested review from
MikaelEdwartz,
jonathanjonathan001,
cchriss123 and
safstromo
Add simple get function Add tests Co-authored-by: Ahlberg-iths <113943951+Ahlberg-iths@users.noreply.github.com>
safstromo
previously approved these changes
Feb 14, 2023
Co-authored-by: Ahlberg-iths <113943951+Ahlberg-iths@users.noreply.github.com>
Co-authored-by: Ahlberg-iths <113943951+Ahlberg-iths@users.noreply.github.com>
safstromo
reviewed
Feb 14, 2023
There was a problem hiding this comment.
I dont think the get method is correct.
If the key exists it should just return the key.
https://redis.io/commands/get/
im assuming this is the same get as #8
There was a problem hiding this comment.
I don't know @safstromo , it seems to be correct to me https://redis.io/commands/get/
See where it says Return: Bulk string reply
jonathanjonathan001
previously approved these changes
Feb 14, 2023
👍 |
safstromo
previously approved these changes
Feb 14, 2023
jLereback
dismissed stale reviews from safstromo and jonathanjonathan001
via
43220a7
|
Kudos, SonarCloud Quality Gate passed! |
jonathanjonathan001
approved these changes
Feb 15, 2023
Svartkettil
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delete function, simple get function and tests