Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log4j2 feature #112

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Add log4j2 feature #112

merged 1 commit into from
Feb 15, 2023

Conversation

VenuModi
Copy link
Contributor

Added log4j2 dependency in pom.xml.
Created a log4j2 class with seperate methods for calling info, warn, error & debug that can be called in other classes. For now we wont save log messages in a file. But if we want to activate it, we can just uncomment the lines in log4j2.xml under the resources folder.

@VenuModi VenuModi linked an issue Feb 15, 2023 that may be closed by this pull request
@VenuModi
Copy link
Contributor Author

Closed the previous branch due to becoming too confusing

#85

safstromo
safstromo previously approved these changes Feb 15, 2023
RehasLiamsi
RehasLiamsi previously approved these changes Feb 15, 2023
Copy link
Contributor

@RehasLiamsi RehasLiamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Added log4j2 dependency in pom.xml.
Created a log4j2 class with seperate methods for calling info, warn, error & debug that can be called in other classes. For now we wont save log messages in a file. But if we want to activate it, we can just uncomment the lines in log4j2.xml under the resources folder.

Rebased main to feature branch
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Viktormes Viktormes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kappsegla kappsegla added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit 637a6d9 Feb 15, 2023
RehasLiamsi
RehasLiamsi approved these changes Feb 15, 2023
@jLereback jLereback deleted the 33-logging-log4j2 branch February 15, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging
6 participants