-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log4j2 feature #112
Merged
Merged
Add log4j2 feature #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed the previous branch due to becoming too confusing |
jonathanjonathan001
previously approved these changes
Feb 15, 2023
safstromo
previously approved these changes
Feb 15, 2023
RehasLiamsi
previously approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Added log4j2 dependency in pom.xml. Created a log4j2 class with seperate methods for calling info, warn, error & debug that can be called in other classes. For now we wont save log messages in a file. But if we want to activate it, we can just uncomment the lines in log4j2.xml under the resources folder. Rebased main to feature branch
fbaa3a3
990f795
to
fbaa3a3
Compare
SonarCloud Quality Gate failed. |
Viktormes
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
jonathanjonathan001
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added log4j2 dependency in pom.xml.
Created a log4j2 class with seperate methods for calling info, warn, error & debug that can be called in other classes. For now we wont save log messages in a file. But if we want to activate it, we can just uncomment the lines in log4j2.xml under the resources folder.