Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commands in executeCommands #134

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Add commands in executeCommands #134

merged 4 commits into from
Feb 17, 2023

Conversation

jLereback
Copy link
Contributor

Add tests where needed

@jLereback
Add commands in executeCommands
96feb24 
Add tests where needed
@jLereback jLereback linked an issue Feb 16, 2023 that may be closed by this pull request
Missing commands in executeCommand #131
Closed
RobertMili
RobertMili previously approved these changes Feb 16, 2023
View reviewed changes
@Henrik-Bengtsson
Copy link
Contributor

Henrik-Bengtsson commented Feb 16, 2023 •
edited
Loading

In HazeDatabaseTest the last test needs a rename. It's called only test now.

Otherwise great work 🥇

@jLereback jLereback force-pushed the 131-missing-commands-in-executecommand branch from fef7572 to 782539a Compare February 16, 2023 14:42
@jLereback @Ahlberg-iths
Update src/main/java/org/fungover/haze/Main.java
6601525 
Co-authored-by: Ahlberg-iths <113943951+Ahlberg-iths@users.noreply.github.com>
@jLereback jLereback force-pushed the 131-missing-commands-in-executecommand branch 3 times, most recently from b7f5a54 to b42d647 Compare February 16, 2023 21:12
@jLereback jLereback force-pushed the 131-missing-commands-in-executecommand branch from b42d647 to a48fc97 Compare February 16, 2023 21:17
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Ahlberg-iths
Ahlberg-iths approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Ahlberg-iths Ahlberg-iths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

safstromo
safstromo approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@safstromo safstromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@jLereback jLereback added this pull request to the merge queue Feb 17, 2023
Merged via the queue into main with commit 0ff5ceb Feb 17, 2023
@jLereback jLereback deleted the 131-missing-commands-in-executecommand branch February 17, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safstromo safstromo safstromo approved these changes

@Ahlberg-iths Ahlberg-iths Ahlberg-iths approved these changes

@RobertMili RobertMili Awaiting requested review from RobertMili

@Henrik-Bengtsson Henrik-Bengtsson Awaiting requested review from Henrik-Bengtsson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing commands in executeCommand
5 participants
@jLereback @Henrik-Bengtsson @safstromo @RobertMili @Ahlberg-iths