Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum to Switch. #157

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Enum to Switch. #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/fungover/haze/Command.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package org.fungover.haze;

public enum Command {
SET, GET, DEL, PING, SETNX, EXISTS, SAVE, RPUSH, LPUSH, LPOP, RPOP, LLEN, LMOVE, LTRIM, AUTH
}
46 changes: 29 additions & 17 deletions src/main/java/org/fungover/haze/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,26 +81,38 @@ private static void printThreadDebug() {
}

public static String executeCommand(HazeDatabase hazeDatabase, List<String> inputList, HazeList hazeList) {
if (inputList.isEmpty() || inputList.get(0).isEmpty()) {
return "-ERR no command provided\r\n";
}

logger.debug("executeCommand: {} {} ", () -> hazeDatabase, () -> inputList);
String command = inputList.get(0).toUpperCase();

return switch (command) {
case "SET" -> hazeDatabase.set(inputList);
case "GET" -> hazeDatabase.get(inputList);
case "DEL" -> hazeDatabase.delete(inputList.subList(1, inputList.size()));
case "PING" -> hazeDatabase.ping(inputList);
case "SETNX" -> hazeDatabase.setNX(inputList);
case "EXISTS" -> hazeDatabase.exists(inputList.subList(1, inputList.size()));
case "SAVE" -> SaveFile.writeOnFile(hazeDatabase.copy());
case "RPUSH" -> hazeList.rPush(inputList);
case "LPUSH" -> hazeList.lPush(inputList);
case "LPOP" -> hazeList.callLPop(inputList);
case "RPOP" -> hazeList.callRpop(inputList);
case "LLEN" -> hazeList.lLen(inputList);
case "LMOVE" -> hazeList.lMove(inputList);
case "LTRIM" -> hazeList.callLtrim(inputList);
case "AUTH" -> "+OK\r\n";
default -> "-ERR unknown command\r\n";
Command commandEnum;

try {
commandEnum = Command.valueOf(command);
} catch (IllegalArgumentException ex) {
return "-ERR unknown command\r\n";
}

return switch (commandEnum) {
case SET -> hazeDatabase.set(inputList);
case GET -> hazeDatabase.get(inputList);
case DEL -> hazeDatabase.delete(inputList.subList(1, inputList.size()));
case PING -> hazeDatabase.ping(inputList);
case SETNX -> hazeDatabase.setNX(inputList);
case EXISTS -> hazeDatabase.exists(inputList.subList(1, inputList.size()));
case SAVE -> SaveFile.writeOnFile(hazeDatabase.copy());
case RPUSH -> hazeList.rPush(inputList);
case LPUSH -> hazeList.lPush(inputList);
case LPOP -> hazeList.callLPop(inputList);
case RPOP -> hazeList.callRpop(inputList);
case LLEN -> hazeList.lLen(inputList);
case LMOVE -> hazeList.lMove(inputList);
case LTRIM -> hazeList.callLtrim(inputList);
case AUTH -> "+OK\r\n";

};
}

Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/fungover/haze/MainTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ void callingExecuteCommandWithValidNonExistingInputReturnsColonOne() {

@Test
void callingExecuteCommandWithInvalidInputStringReturnsErrorMessage() {
assertThat(Main.executeCommand(database, List.of(""), hazeList)).isEqualTo("-ERR unknown command\r\n");
assertThat(Main.executeCommand(database, List.of(""), hazeList)).isEqualTo("-ERR no command provided\r\n");

}

@Test
Expand Down