-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
156 databases are split so many commands dont work with lists #158
156 databases are split so many commands dont work with lists #158
Conversation
Add copy of libraries Update Entrypoint classpath
2. Catch all errors 3. Fix merge conflicting
74c5e21
to
36ae08c
Compare
…t-work-with-lists
…-lists' of https://github.com/fungover/haze into 156-databases-are-split-so-many-commands-dont-work-with-lists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cchriss123 Code looks good and all command seems to do the right thing with the lists but when trying unit tests lpush and rpush seems to return the wrong value. They are supposed to return the length of the list for that key after doing the changes.
assertThat(pool.lpush("test", "first")).isEqualTo(1);
assertThat(pool.lpush("test", "second")).isEqualTo(2);
This will fail on the second line where lpush returns 1 but should be 2?
I verified this behavior against redis as a benchmark.
|
Changes some variabel names in HazeList tests.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are green and integration tests works as expected now.
HazeList is now reworked to save in the same database as the rest of the program.