Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

156 databases are split so many commands dont work with lists #158

Merged

Conversation

cchriss123
Copy link
Contributor

HazeList is now reworked to save in the same database as the rest of the program.

RobertMili
RobertMili previously approved these changes Feb 19, 2023
RobertMili
RobertMili previously approved these changes Feb 20, 2023
@cchriss123 cchriss123 added feature Marks a pull request as a new feature bug Something isn't working and removed minor labels Feb 20, 2023
cchriss123 and others added 4 commits February 20, 2023 18:25
Add copy of libraries
Update Entrypoint classpath
2. Catch all errors
3. Fix merge conflicting
@cchriss123 cchriss123 force-pushed the 156-databases-are-split-so-many-commands-dont-work-with-lists branch from 74c5e21 to 36ae08c Compare February 20, 2023 17:28
Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cchriss123 Code looks good and all command seems to do the right thing with the lists but when trying unit tests lpush and rpush seems to return the wrong value. They are supposed to return the length of the list for that key after doing the changes.

assertThat(pool.lpush("test", "first")).isEqualTo(1);
assertThat(pool.lpush("test", "second")).isEqualTo(2);

This will fail on the second line where lpush returns 1 but should be 2?

I verified this behavior against redis as a benchmark.

@cchriss123
Copy link
Contributor Author

cchriss123 commented Feb 25, 2023

@cchriss123 Code looks good and all command seems to do the right thing with the lists but when trying unit tests lpush and rpush seems to return the wrong value. They are supposed to return the length of the list for that key after doing the changes.

assertThat(pool.lpush("test", "first")).isEqualTo(1); assertThat(pool.lpush("test", "second")).isEqualTo(2);

This will fail on the second line where lpush returns 1 but should be 2?

I verified this behavior against redis as a benchmark.
@kappsegla
Good catch. It should be fixed now.

@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.8% 94.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are green and integration tests works as expected now.

@kappsegla kappsegla merged commit 0a5ca0f into main Mar 4, 2023
@kappsegla kappsegla deleted the 156-databases-are-split-so-many-commands-dont-work-with-lists branch March 4, 2023 14:40
@kappsegla kappsegla added minor and removed feature Marks a pull request as a new feature labels Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Databases are split so many commands don't work with lists
4 participants