50 Adding integration tests #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests that starts the server on a random free port. Tests for the following commands: PING - PONG SETNX SET - GET DELETE EXISTS Error for not implemented command
Change initialization of ServerSocket setReuseAddress true to happen before binding. Otherwise, the reuse address option doesn't work.
…-lists' into 50-integration-tests # Conflicts: # src/main/java/org/fungover/haze/Main.java # src/test/java/org/fungover/haze/MainTest.java
When running tests testcontainers uses slf4j to do logging. Without an implementation an error message will be printed.
…commands-dont-work-with-lists' into 50-integration-tests # Conflicts: # src/test/java/org/fungover/haze/MainTest.java
Before building new docker images during release integration tests will be run. The command is now mvn -B verify.
kappsegla
added
dependencies
Closed
|
SonarCloud Quality Gate failed. |
cmatlak
reviewed
Feb 2, 2024
robinalfengard
previously approved these changes
Feb 2, 2024
Integration tests that starts the server on a random free port. Tests for the following commands: PING - PONG SETNX SET - GET DELETE EXISTS Error for not implemented command
Change initialization of ServerSocket setReuseAddress true to happen before binding. Otherwise, the reuse address option doesn't work.
When running tests testcontainers uses slf4j to do logging. Without an implementation an error message will be printed.
Before building new docker images during release integration tests will be run. The command is now mvn -B verify.
robinalfengard
previously approved these changes
Feb 6, 2024
kappsegla
dismissed
robinalfengard’s stale review
The merge-base changed after approval.
cmatlak
previously approved these changes
Feb 6, 2024
kappsegla
dismissed
cmatlak’s stale review
The merge-base changed after approval.
|
conflicts should be resolved by @kappsegla ? |
# Conflicts: # Dockerfile # src/main/java/org/fungover/haze/Main.java
|
cmatlak
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add integration tests that can be used to check that the built docker image can be started and the server called.
The following updates are included:
Changes to the Dockerfile, dependencies are now downloaded here and not by maven.
Github action release.yml now runs mvn verify to verify the application before publishing anything.
Disables generation of a jar file during maven build process because it's not needed. Classes will be copied directly into docker image anyway.