Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependabot.yml #36

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

jLereback
Copy link
Contributor

@jLereback jLereback commented Feb 4, 2023

Added dependabot with weekly updates for Github Actions, Maven and Docker

@jLereback jLereback linked an issue Feb 4, 2023 that may be closed by this pull request
Copy link
Contributor

@MikaelEdwartz MikaelEdwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code for dependabot looks good! However yml file is missing a newline at the end

@jLereback
Copy link
Contributor Author

New line at the end is added, Thanks @MikaelEdwartz

MikaelEdwartz
MikaelEdwartz previously approved these changes Feb 4, 2023
@kappsegla
Copy link
Contributor

Looks like we have a recurring problem with missing newline at the last line in some textfiles.

This is how a line is defined in POSIX standard:

A sequence of zero or more non- characters plus a terminating character.

Something for .editorconfig #28 to fix so all developers have this enabled.

Can also be set in IntelliJ directly.
image

.github/dependabot.yml Show resolved Hide resolved
Ahlberg-iths
Ahlberg-iths previously approved these changes Feb 6, 2023
Copy link
Contributor

@Ahlberg-iths Ahlberg-iths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

MikaelEdwartz
MikaelEdwartz previously approved these changes Feb 7, 2023
Add new line at the end

Update interval in dependabot.yml

Update .github/dependabot.yml

Add new line at the end once again

Co-authored-by: Ahlberg-iths <113943951+Ahlberg-iths@users.noreply.github.com>
Copy link
Contributor

@williamDenStore williamDenStore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@signealfonson
Copy link
Contributor

Well noticed @MikaelEdwartz! Amazing dependabot @jLereback 💗

@kappsegla kappsegla merged commit cff9340 into main Feb 8, 2023
@kappsegla kappsegla deleted the 5-enable-dependabot-version-updates branch February 8, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable dependabot version updates
6 participants