Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HazeDatabase: Change access modifiers to public and add parameters #65

Merged
merged 1 commit into from
Feb 10, 2023
Merged

HazeDatabase: Change access modifiers to public and add parameters #65

merged 1 commit into from
Feb 10, 2023

Conversation

jonathanjonathan001
Copy link
Contributor

Also, remove static from fields (SonarLint complained).

See if you approve of the changes I made!

Fixes #64

@jonathanjonathan001
Change access modifiers to public and add parameters
ee1246b 
Also, remove static from fields (SonarLint complained)
@jonathanjonathan001 jonathanjonathan001 linked an issue Feb 9, 2023 that may be closed by this pull request
HazeDatabase, private methods and parameters missing #64
Closed
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonathanjonathan001
Copy link
Contributor Author

SonarClouds code smells are understandable since we haven't implemented the methods yet!

MikaelEdwartz
MikaelEdwartz approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@MikaelEdwartz MikaelEdwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paramaters were left out intentionally for the implementer. Nice implementation

safstromo
safstromo approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@safstromo safstromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kappsegla kappsegla merged commit 4b4c2e3 into main Feb 10, 2023
@kappsegla kappsegla deleted the 64-hazedatabase-update branch February 10, 2023 08:34
jLereback
jLereback reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jLereback jLereback jLereback left review comments

@safstromo safstromo safstromo approved these changes

@MikaelEdwartz MikaelEdwartz MikaelEdwartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HazeDatabase, private methods and parameters missing
5 participants
@jonathanjonathan001 @safstromo @MikaelEdwartz @jLereback @kappsegla