Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scope test in pom.xml #92

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Added scope test in pom.xml #92

merged 2 commits into from
Feb 13, 2023

Conversation

Anton20HD
Copy link
Contributor

Added scope test in pom.xml

@Anton20HD Anton20HD linked an issue Feb 13, 2023 that may be closed by this pull request
Viktormes

This comment was marked as duplicate.

xCandyFun
xCandyFun previously approved these changes Feb 13, 2023
Copy link
Contributor

@xCandyFun xCandyFun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@kappsegla
Copy link
Contributor

kappsegla commented Feb 13, 2023

@Anton20HD What about assertj and mockito dependencies?

@Anton20HD Anton20HD dismissed stale reviews from xCandyFun and Viktormes via 1823c75 February 13, 2023 12:42
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anton20HD
Copy link
Contributor Author

Anton20HD commented Feb 13, 2023

Thats right! Updated the pom.xml file now

Copy link
Contributor

@Viktormes Viktormes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better now. Good point on what was missing @kappsegla

@kappsegla kappsegla added this pull request to the merge queue Feb 13, 2023
Merged via the queue into main with commit e00b749 Feb 13, 2023
@kappsegla kappsegla deleted the 89-scope-test-in-pomxml branch February 13, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope test in pom.xml
4 participants