Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 sonarcloud test coverage #96

Merged
merged 2 commits into from
Feb 15, 2023
Merged

72 sonarcloud test coverage #96

merged 2 commits into from
Feb 15, 2023

Conversation

ArmanAlemirad
Copy link
Contributor

Add jacco, surfire and failsafe to see if covaragestatus is enable

@ArmanAlemirad ArmanAlemirad linked an issue Feb 13, 2023 that may be closed by this pull request
@ArmanAlemirad
Copy link
Contributor Author

In order to see test coverage you have to visit :
https://sonarcloud.io/project/overview?id=fungover_haze

Sonarcloud bot doesn't show the coverage yet.

Skärmbild 2023-02-13 150756

@safstromo
Copy link
Contributor

Is there a way to see if it works?
If i go to your link its still 0.0% Coverage.
And i cant use the maven command added since it asks for tokens.

Screenshot from 2023-02-14 11-19-18

@ArmanAlemirad
Copy link
Contributor Author

I think, once it's merged into the main, it will be able to cover the test. Till then, I don't think it will do that

@ArmanAlemirad
Copy link
Contributor Author

Is there a way to see if it works? If i go to your link its still 0.0% Coverage. And i cant use the maven command added since it asks for tokens.

Screenshot from 2023-02-14 11-19-18

You cant se the coverage when you run the code locally, due to we have give this repository sonar_token key. Therefor sonar cant find the project .

@kappsegla
Copy link
Contributor

Is there a way to see if it works? If i go to your link its still 0.0% Coverage. And i cant use the maven command added since it asks for tokens.

Screenshot from 2023-02-14 11-19-18

Are you looking at a branch containing changes that includes java code or java test code? If it's only changes to config files or CI/CD files no changed test coverage will be calculated for the branch linked to a PR.
After merging into main branch we should get a total test coverage calculated for our project as @ArmanAlemirad says. Let us merge this first and then we can rerun the sonarcloud for some of the waiting pull requests and see if there test coverage for the new code is above 80%.

kappsegla
kappsegla previously approved these changes Feb 14, 2023
safstromo
safstromo previously approved these changes Feb 14, 2023
ArmanAlemirad and others added 2 commits February 15, 2023 09:19
Co-authored-by: ArmanAlemirad <112554095+armanalemirad@users.noreply.github.com>
@kappsegla kappsegla dismissed stale reviews from safstromo and themself via f48cc2b February 15, 2023 08:24
@kappsegla kappsegla added this pull request to the merge queue Feb 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Merged via the queue into main with commit 746e20f Feb 15, 2023
@jLereback jLereback deleted the 72-sonarcloud-test-coverage branch February 16, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarCloud test coverage
4 participants