Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain Syntax test not 100% accurate #17

Closed
speedmann opened this issue Jan 2, 2019 · 2 comments
Closed

Domain Syntax test not 100% accurate #17

speedmann opened this issue Jan 2, 2019 · 2 comments
Assignees
@funilrys
Labels
bug enhancement

Comments

@speedmann
Copy link

Describe the bug
When testing for domain syntax a valid case is rejected with "INVALID".

Modifications under .PyFunceble.yaml
None

To Reproduce
Steps to reproduce the behavior:

$ pyfunceble -d google.de. -s
google.de. INVALID

$ curl google.de.
<HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
<TITLE>301 Moved</TITLE></HEAD><BODY>
<H1>301 Moved</H1>
The document has moved
<A HREF="http://www.google.de/">here</A>.

Expected behavior
Domains ending with a dot are verified valid and tested if they are available

Versions (please complete the following information):

  • OS: macos mojave
  • Python Version: 3.6.7
  • PyFunceble Version: pyfunceble 1.3.0. (Blue Bontebok: Dragonfly)

Additional context
I guess this is nitpicking over what is a valid domain syntax and what not. Also the mentioned syntax might be quiet uncommon.
But if syntax validation is offered, the check should return reliable results.
Additional Information http://www.dns-sd.org./TrailingDotsInDomainNames.html
@funilrys funilrys self-assigned this Jan 3, 2019
@funilrys
Copy link
Owner

funilrys commented Jan 3, 2019

Hi @speedmann,
Thanks for the feedback! I forgot about those one.

Will fix asap!

Cheers,
Nissar

@funilrys
Copy link
Owner

funilrys commented Jan 3, 2019

Fix introduced with 2fce8b6.

It's now available in the dev version.

P.S: Please DO NOT close this issue manually. This issue is gonna be closed automatically once 2fce8b6 will be merged to master/stable version.

@funilrys funilrys mentioned this issue Jan 4, 2019
Closed
funilrys added a commit that referenced this issue Jan 5, 2019
@funilrys
Introduction of 1.6.0 (Blue Bontebok: Grasshopper)
6270600 
It's always great to get feedback :)

Fix:

- of the test/check of DNS names which ends with `.` (#17).
- of the `--filter` argument which was not working if a special
character was given.
- of the way we clean and construct the list we have to test. (#18)

Review:

- of the way we check syntaxes.
- of the way we produce outputs for elements which are already
registered into the database. (#16)
- of the way we remove an element from the database.
- of the way we merge upstream with the local configuration file.

Contributors:

- @dnmTX
- @jawz101
- @speedmann
@funilrys funilrys mentioned this issue Nov 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@funilrys funilrys

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@speedmann @funilrys