Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Special Rules for imgur.com #319

Closed
smed79 opened this issue Nov 9, 2022 · 1 comment
Closed

FEATURE: Special Rules for imgur.com #319

smed79 opened this issue Nov 9, 2022 · 1 comment
Assignees
@funilrys
Labels
enhancement features

Comments

@smed79
Copy link
Contributor

smed79 commented Nov 9, 2022 •
edited

① - deleted / removed imgur.com images are shown by PyFunceble as ACTIVE.

$ PyFunceble -u https://i.imgur.com/yDoCnHk.png

Subject                             Status        Source
------------------                  -----------   ----------
https://i.imgur.com/yDoCnHk.png     ACTIVE        HTTP CODE

$ curl -I https://i.imgur.com/yDoCnHk.png

HTTP/2 302 
location: https://i.imgur.com/removed.png

② - unexisting user custom domain is shown by PyFunceble as ACTIVE.

$ PyFunceble -u https://vh7faflpemfm.imgur.com/

Subject                             Status        Source
------------------                  -----------   ----------
https://vh7faflpemfm.imgur.com/     ACTIVE        HTTP CODE

$ curl -I https://vh7faflpemfm.imgur.com/

HTTP/2 301 
location: https://imgur.com/user/vh7faflpemfm
@spirillen spirillen mentioned this issue Nov 23, 2022
Closed
@funilrys
Copy link
Owner

@smed79 there is nothing we can do for your second case.

  • I can flag https://vh7faflpemfm.imgur.com/ as INACTIVE because it redirects to https://imgur.com/user/vh7faflpemfm
  • But I can't flag https://imgur.com/user/vh7faflpemfm as INACTIVE if the user doesn't exist because imgur.com is showing a 404 page but the status code is still 200. And there is nothing to parse because it's a SPA that loads its content when javascript spins up.

funilrys added a commit that referenced this issue Dec 28, 2022
@funilrys
Introduction of the imgur.com SPECIAL rule.
266f0a5 
This patch fixes #319.

Indeed, before this patch we weren't handling the case that a
hosted image or user has been deleted.

Contributors:
  * @smed79
funilrys added a commit that referenced this issue Dec 28, 2022
@funilrys
Introduction of the imgur.com SPECIAL rule.
22d9dff 
This patch fixes #319.

Indeed, before this patch we weren't handling the case that a
hosted image or user has been deleted.

Contributors:
  * @smed79
funilrys added a commit that referenced this issue Jan 8, 2023
@funilrys
Introduction of the support for postgresql.
ef149c6 
Squashed commit of the following:

commit e0a35bd
Author: funilrys <contact@funilrys.com>
Date:   Sun Jan 8 10:24:16 2023 +0100

    fixup! Introduction of the support for postgresql DBs.

commit 0239f55
Author: funilrys <contact@funilrys.com>
Date:   Wed Dec 28 16:01:19 2022 +0100

    fixup! Introduction of the support for postgresql DBs.

commit 942f5f8
Author: funilrys <contact@funilrys.com>
Date:   Wed Dec 28 15:47:59 2022 +0100

    fixup! Introduction of the support for postgresql DBs.

commit 9f4628b
Author: funilrys <contact@funilrys.com>
Date:   Wed Dec 28 15:41:23 2022 +0100

    fixup! Introduction of the support for postgresql DBs.

commit 975bf25
Author: funilrys <contact@funilrys.com>
Date:   Wed Dec 28 15:34:35 2022 +0100

    Introduction of the support for postgresql DBs.

    Indeed, before this patch, user couldn't use their postgresql
    databases along with PyFunceble.

commit 22d9dff
Author: funilrys <contact@funilrys.com>
Date:   Mon Dec 26 15:41:56 2022 +0100

    Introduction of the imgur.com SPECIAL rule.

    This patch fixes #319.

    Indeed, before this patch we weren't handling the case that a
    hosted image or user has been deleted.

    Contributors:
      * @smed79
funilrys added a commit that referenced this issue May 29, 2023
@funilrys
Introduction of PyFunceble v4.2.0 (Blue Duckling: Ixora)!
4034e54 
Fixed:
  * Security / Dependency Management: cryptography
    Mitigation of CVE-2023-0286 & CVE-2023-23931 through
    version bump.
  * Fatal Error: When no nameservers are configured or provided by the
    hosting system. (#328)
  * Semantic: git.io (#341)
    URLs with git.io were replaced with other one.
  * New linting issues.

Improved:
  * SPECIAL Rules: weebly.com
    We now take down subdomains that return the 406 status code.
  * SPECIAL Rules: wordpress.com (#321)
    We now recognize subjects that were took down by Wordpress.
  * SPECIAL Rules: internal
    Uniformiization of the method for better and quicker development.
  * Dependency Management: sqlalchemy
    We upgraded to SQLAlchemy v2.x+.
  * Converters: internal
    Convertion can now be performed directely without initialization of
    subjects through the convet method.

Removed:
  * Python Support: <=3.7
    We do not test or support any usage of PyFunceble with python<=3.7.

New:
  * Python Support: ~=3.11
    We now test (CI/CD) and support python~=3.11.
  * Testing: pytest (#328)
    pytest can now be used by packager to tests pyfunceble before
    deployment.
  * Database: PostgreSQL
    We now support PostgreSQL as database type.
  * Filesystem: IPs as first-class citizens in plain text outputs (#268)
    From now on, IPs will be stored into the `ips` subdirectory when the
    plain text format is active.
  * SPECIAL Rules: subject-switch (#185 | #185#issuecomment-1290866362)
    We now support the subject switch from any domains.
    For example:

    - m.example.com -> example.com
      Outcome: m.example.com as INACTIVE
    - m.example.com -> example.org
      Outcome: NO status switch.
    - m.example.com -> a.example.com -> example.com
      Outcome: m.example.com as INACTIVE.
    - m.example.com/hello/world -> example.com/hello/world
      Outcome: m.example.com/hello/world as INACTIVE.
  * SPECIAL Rules: changeip (#311)
    When one of the known changeip domains provides `abuse.change.com`
    in the SOA record, the subject will be flagged as INACTIVE.
  * SPECIAL Rules: imgur.com (#319)
    We now flag removed images.
  * SPECIAL Rules: eToxic (#334)
    When a blog from the eToxic infrastructure (known domains) doesn't
    exists anymore, we flag them as INACTIVE.

Contributors:
  * @Nilsonfsilva
  * @smed79
  * @spirilln
  * @T145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@funilrys funilrys

Labels
enhancement features
Projects
#PyFunceble Backlog
Archived in project
#PyFunceble Features
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Special Rules imgur.com
2 participants
@smed79 @funilrys