Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt obtaining selected subgraph #94

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Adapt obtaining selected subgraph #94

merged 1 commit into from
Apr 24, 2024

Conversation

lmanan
Copy link
Contributor

@lmanan lmanan commented Apr 24, 2024

Minor change to existing code.

Select nodes and edges for which the value of the [node/edge] selected indicator variable > 0.5, instead of checking for them being equal to 1, since the latter can skip nodes and edges for which the value of the indicator variable is 1.0000002 etc.

Referred here.

for which value of indicator > 0.5.
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (5415cd4) to head (06608fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files          33       33           
  Lines         812      812           
=======================================
  Hits          761      761           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tlambert03 tlambert03 merged commit 1216dec into funkelab:main Apr 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants