Remove non-existent keys polyfill #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ember/polyfills has never exported keys
|
@stevensona thanks for the PR! Interesting that it became an error now. Which version of ember are you using? |
fsmanuel
approved these changes
Jul 29, 2023
fsmanuel
changed the title
Error on latest ember (5.1) when importing the adapter. |
|
@stevensona thanks again. I released v2.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ember/polyfills has never included a polyfill for Object.keys, to my knowledge. import fails.
https://github.com/emberjs/ember.js/blob/v4.4.0/packages/%40ember/polyfills/index.ts