Feature/prettyprint #7
Conversation
src/dshould/package.d
Outdated
| { | ||
| if (got != value) | ||
| { | ||
| stringCmpError(gotString, valueString, false, file, line); |
There was a problem hiding this comment.
consider replacing false with No.quoted
| should.terminateChain; | ||
|
|
||
| auto got = should.got(); | ||
| const gotString = got.to!string.prettyprint; |
There was a problem hiding this comment.
Usually, we do .to!(string[]) in this case. Is .to!string safe?
Or is it possible, that the string representation of one array element contains an unmatched parenthesis that results in an unwanted parse tree of the array?
There was a problem hiding this comment.
In the case of an unmatched parenthesis, the parse tree will fail to be constructed and we will fall back to ordinary string comparison.
src/dshould/stringcmp.d
Outdated
| should.addWord!"equal".stringCmp(expected, file, line); | ||
| if (got != expected) | ||
| { | ||
| stringCmpError(got, expected, true, file, line); |
src/dshould/prettyprint.d
Outdated
|
|
||
| /** | ||
| * This function takes the input text and returns a pretty-printed, multiline, indented version. | ||
| * It assumes that the input text is the output of toString and forms a valid comma separated paren tree. |
There was a problem hiding this comment.
Add hint like "the output of a structured toString"?
Our toString style is idiosyncratic and this function best suits this style:
- more machine-readable
__repr__than human-readable__str__ - one-liner (for better
grepresults) rather than preformatted
There was a problem hiding this comment.
example added
src/dshould/prettyprint.d
Outdated
|
|
||
| prettyprint("Foo()").should.equal("Foo()"); | ||
| prettyprint("Foo(Bar(Baz()), Baq())", 16).should.equal( | ||
| "Foo( |
There was a problem hiding this comment.
Consider using correct code indentation and fixing it with outdent.
src/dshould/prettyprint.d
Outdated
| return; | ||
| } | ||
|
|
||
| result ~= tree.prefix.stripLeft; |
src/dshould/prettyprint.d
Outdated
| result ~= ","; | ||
| } | ||
| result ~= "\n"; | ||
| (level + 1).iota.each!((_) { result ~= indent; }); |
There was a problem hiding this comment.
repeat and join force an extra allocation.
src/dshould/prettyprint.d
Outdated
| Appender!string result; | ||
|
|
||
| // skip prefix so caller can decide whether or not to strip | ||
| void walkOneLine(const Tree tree) |
There was a problem hiding this comment.
Nested functions aren't reorderable. (And can't be, because they close over scopes.)
src/dshould/prettyprint.d
Outdated
| tree.children.enumerate.each!((index, child) { | ||
| if (index > 0) | ||
| { | ||
| result ~= ","; |
There was a problem hiding this comment.
Isn't it ", " - with space after comma?
There was a problem hiding this comment.
Spacing is as in the original string.
src/dshould/prettyprint.d
Outdated
| result ~= tree.parenType.get.closing; | ||
| } | ||
|
|
||
| void walk(size_t level, const Tree tree) |
There was a problem hiding this comment.
"walk" suggests how the function is implemented - "traverse" would be a similar bad name, that's only appropriate for a template where the what is a template parameter.
A specific function, however, should better be named for the *what and not for the how: something like render
FeepingCreature
force-pushed
the
feature/prettyprint
branch
2 times, most recently
from
db5eb36
to
84ab585
Compare
|
Moved to an external package. |
FeepingCreature
force-pushed
the
feature/prettyprint
branch
from
112f29d
to
ced2800
Compare
@linkrope ping