Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parsers.py #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

garrythezany
Copy link

Hello again!

If the container-labels for a single service are omitted, the deck-chores service fails and dies:

[...]
    labels:
       deck-chores.command: "echo hello"
       deck-chores.interval: "hourly"
[...]

The trailing commit fixes the service failing on misconfigured/broken job label definitions,
and prints an error instead.

Sorry for missing / failing tests.

Thanks!

Fix service failing on misconfigured/broken job label definition, print an error instead
@funkyfuture
Copy link
Owner

sorry, but this certainly requires tests. i'm also having trouble to understand what your description and example have to do with the proposed change.

@Sadrak
Copy link

Sadrak commented Apr 27, 2022

A new coworker missspelled the label (forgot the naming part) and the parser broke the hole deck-chores container. The container fainted with a python split/parse error.

[...]
    labels:
       deck-chores.command: "echo hello"
       deck-chores.interval: "hourly"
[...]

VS

[...]
    labels:
       deck-chores.name-for-cron.command: "echo hello"
       deck-chores.name-for-cron.interval: "hourly"
[...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants